New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raises error when user tries to update an existing service to Rolling… #4085

Open

KrishivPiduri wants to merge 1 commit into skypilot-org:master from KrishivPiduri:new-issue

Contributor

KrishivPiduri commented Oct 14, 2024 •

edited

Loading

… mode. #4066

Added a couple lines of code to disallow users from altering a service such as to put it in rolling mode.

format.sh

Tested (run the relevant ones):

Code formatting: bash format.sh
Any manual or new tests for this PR (please specify below)
All smoke tests: pytest tests/test_smoke.py
Relevant individual smoke tests: pytest tests/test_smoke.py::test_fill_in_the_name
Backward compatibility tests: conda deactivate; bash -i tests/backward_compatibility_tests.sh


Raises error when user tries to update an existing service to Rolling…

501603e

… mode. skypilot-org#4066

KrishivPiduri marked this pull request as ready for review

October 14, 2024 22:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment